Port the glm4.5v model. #1962
Open
Port the glm4.5v model. #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just make the model work, do not need to merge this patch. Someone should change this later in another PR.
HeJunyan
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
czhu15
requested changes
Oct 24, 2025
| # the static and dynamic parts distinct. | ||
| if htorch.utils.internal.is_lazy(): | ||
| if self.model_is_mrope and hasattr(self.model, 'visual'): | ||
| if 0:#self.model_is_mrope and hasattr(self.model, 'visual'): |
There was a problem hiding this comment.
pls don't hard code the check. This will break other models I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance and benchmark of this model will be provided later.